-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy and translations for 'importing ___' progress step messages for NetSuite #47749
Conversation
@techievivek Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Thanks for creating @yuwenmemon. Does this need checklist? |
src/languages/es.ts
Outdated
@@ -3268,6 +3268,12 @@ export default { | |||
return 'Actualizando información de conexión'; | |||
case 'netSuiteSyncNetSuiteReimbursedReports': | |||
return 'Marcando informes de Expensify como reembolsados'; | |||
case 'netSuiteSyncImportCustomLists': | |||
return 'Importando listas personalizado'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this verified? I would have said Importando listas personalizadas
off the top of my head.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're using personalizado
at quite a few places. Does that mean we should it update it at other places too? I think we had used DeepL for these translations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word personalizado
by itself is fine, it's the adjective agreement that doesn't work here. listas
is plural and feminine, so the adjective after it should be matched accordingly. We have other translations that already follow this, e.g.:
un calendario personalizado
(calendario is singular and masculine)Establece una descripción personalizada
(singular feminine)Controles de gastos y límites personalizados
(plural masculine)
case 'netSuiteSyncImportCustomLists': | ||
return 'Importando listas personalizado'; | ||
case 'netSuiteSyncImportSubsidiaries': | ||
return 'Importando subsidiarias'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this one, sounds like subsidiario/a
is more commonly used as an adjective, whereas the noun would be filial
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subsidiarias
is what NetSuite uses in product when you turn it into Spanish 🤷🏽♂️
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.23-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.23-0 🚀
|
@francoisl please review
cc @mananjadhav
Details
Connected to https://github.com/Expensify/Integration-Server/pull/8066, adds the translations for these progress sub-steps
Fixed Issues
None, just reported by @mananjadhav
Tests/QA
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop